repo stringclasses 1
value | instance_id stringlengths 22 24 | problem_statement stringlengths 24 24.1k | patch stringlengths 0 1.9M | test_patch stringclasses 1
value | created_at stringdate 2022-11-25 05:12:07 2025-10-09 08:44:51 | hints_text stringlengths 11 235k | base_commit stringlengths 40 40 |
|---|---|---|---|---|---|---|---|
juspay/hyperswitch | juspay__hyperswitch-2225 | Bug: [FEATURE]: [Fiserv] Currency Unit Conversion
### :memo: Feature Description
- Each currency can be described in terms of base or minor units.
- For instance, when dealing with USD currency, the Cent is considered as the minor unit, while the Dollar is considered the base unit.
- In Hyperswitch, the amount va... | diff --git a/crates/router/src/connector/fiserv.rs b/crates/router/src/connector/fiserv.rs
index 70f58ffe6eb..35d40f1a3fb 100644
--- a/crates/router/src/connector/fiserv.rs
+++ b/crates/router/src/connector/fiserv.rs
@@ -104,6 +104,10 @@ impl ConnectorCommon for Fiserv {
"fiserv"
}
+ fn get_currency_... | 2023-10-28T02:46:57Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
- Addressing Issue: #2225
- Modified two files in `hyperswitch/crates/router/src/connector/`
- `fise... | 53b8fefbc2f8b58d1be7e9f35ca8b7e44e327bfb | |
juspay/hyperswitch | juspay__hyperswitch-2223 | Bug: [FEATURE]: [Dlocal] Currency Unit Conversion
### :memo: Feature Description
- Each currency can be described in terms of base or minor units.
- For instance, when dealing with USD currency, the Cent is considered as the minor unit, while the Dollar is considered the base unit.
- In Hyperswitch, the amount va... | diff --git a/crates/router/src/connector/dlocal.rs b/crates/router/src/connector/dlocal.rs
index 90be2399ba0..b706d694a3d 100644
--- a/crates/router/src/connector/dlocal.rs
+++ b/crates/router/src/connector/dlocal.rs
@@ -109,6 +109,10 @@ impl ConnectorCommon for Dlocal {
"dlocal"
}
+ fn get_currency_... | 2023-10-17T13:50:19Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
- Addressing Issue: #2223
- Modified two files in `hyperswitch/crates/router/src/connector/`
- `dloc... | 6cf8f0582cfa4f6a58c67a868cb67846970b3835 | |
juspay/hyperswitch | juspay__hyperswitch-2222 | Bug: [FEATURE]: [Cybersource] Currency Unit Conversion
### :memo: Feature Description
- Each currency can be described in terms of base or minor units.
- For instance, when dealing with USD currency, the Cent is considered as the minor unit, while the Dollar is considered the base unit.
- In Hyperswitch, the amou... | diff --git a/crates/router/src/connector/cybersource.rs b/crates/router/src/connector/cybersource.rs
index d1ad36b26d1..0a13aa0cf14 100644
--- a/crates/router/src/connector/cybersource.rs
+++ b/crates/router/src/connector/cybersource.rs
@@ -93,6 +93,10 @@ impl ConnectorCommon for Cybersource {
connectors.cyber... | 2023-10-18T09:03:55Z | ## Type of Change
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This PR implements `get_currency_unit` for cybersource to convert payments from `Base` to `Minor` it also implements router data to handle the convers... | 664093dc79743203196d912c17570885718b1c02 | |
juspay/hyperswitch | juspay__hyperswitch-2221 | Bug: [FEATURE]: [Coinbase] Currency Unit Conversion
### :memo: Feature Description
- Each currency can be described in terms of base or minor units.
- For instance, when dealing with USD currency, the Cent is considered as the minor unit, while the Dollar is considered the base unit.
- In Hyperswitch, the amount ... | diff --git a/crates/router/src/connector/coinbase.rs b/crates/router/src/connector/coinbase.rs
index d50e490cfc3..5b9bedbd9c1 100644
--- a/crates/router/src/connector/coinbase.rs
+++ b/crates/router/src/connector/coinbase.rs
@@ -74,6 +74,10 @@ impl ConnectorCommon for Coinbase {
"coinbase"
}
+ fn get... | 2023-10-20T17:28:07Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Dependency updates
- [x] Refactoring
- [ ] Documentation
- [ ] CI/CD
## Description
This pull request introduces the get_currecny_unit from ConnectorCommon trait for `CoinBase`. This functio... | 8e484ddab8d3f4463299c7f7e8ce75b8dd628599 | |
juspay/hyperswitch | juspay__hyperswitch-2220 | Bug: [FEATURE]: [BitPay] Currency Unit Conversion
### :memo: Feature Description
- Each currency can be described in terms of base or minor units.
- For instance, when dealing with USD currency, the Cent is considered as the minor unit, while the Dollar is considered the base unit.
- In Hyperswitch, the amount va... | diff --git a/crates/router/src/connector/bitpay.rs b/crates/router/src/connector/bitpay.rs
index 2dc634426f3..e8826e93390 100644
--- a/crates/router/src/connector/bitpay.rs
+++ b/crates/router/src/connector/bitpay.rs
@@ -82,6 +82,10 @@ impl ConnectorCommon for Bitpay {
"bitpay"
}
+ fn get_currency_un... | 2023-10-30T14:53:06Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the API co... | 0a44f5699ed7b0c0ea0352b67c65df496ebe61f3 | |
juspay/hyperswitch | juspay__hyperswitch-2215 | Bug: [FEATURE]: [Airwallex] Currency Unit Conversion
### :memo: Feature Description
- Each currency can be described in terms of base or minor units.
- For instance, when dealing with USD currency, the Cent is considered as the minor unit, while the Dollar is considered the base unit.
- In Hyperswitch, the am... | diff --git a/crates/router/src/connector/airwallex.rs b/crates/router/src/connector/airwallex.rs
index 8a22c14dd32..8ef7ba08211 100644
--- a/crates/router/src/connector/airwallex.rs
+++ b/crates/router/src/connector/airwallex.rs
@@ -66,6 +66,10 @@ impl ConnectorCommon for Airwallex {
"airwallex"
}
+ ... | 2023-10-13T07:44:28Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
- Addressing Issue: #2215
- Modified two files in `hyperswitch/crates/router/src/connector/`
- `airwa... | 500405d78938772e0e9f8e3ce4f930d782c670fa | |
juspay/hyperswitch | juspay__hyperswitch-2205 | Bug: [FEATURE]: [ACI] Use `connector_response_reference_id` as reference to merchant
### :memo: Feature Description
- Reference id are used to map transactions in the connector’s dashboard.
- Hyperswitch manages several reference ids, such as `payment_id`, `attempt_id`, and `connector_transaction_id` for a single t... | diff --git a/crates/router/src/connector/aci/transformers.rs b/crates/router/src/connector/aci/transformers.rs
index 7d30c80c49c..f6c1daffe4d 100644
--- a/crates/router/src/connector/aci/transformers.rs
+++ b/crates/router/src/connector/aci/transformers.rs
@@ -682,12 +682,12 @@ impl<F, T>
}
... | 2023-10-11T17:54:29Z | ## Type of Change
- [x] New feature
## Description
The connector_response_reference_id parameter has been set for the ACIs Payment Solutions for uniform reference and transaction tracking.
## File Changes
This PR modifies the Aci Transformers file.
Location- router/src/connector/aci/transformers.rs
## Mot... | 3807601ee1c140310abf7a7e6ee4b83d44de9558 | |
juspay/hyperswitch | juspay__hyperswitch-2203 | Bug: [FEATURE]: [ACI] Use `connector_request_reference_id` as reference to the connector
### :memo: Feature Description
- We transmit our reference id from Hyperswitch to the connector, enabling merchants to subsequently locate the payment within the connector dashboard.
- Presently, there is a lack of uniformity ... | diff --git a/crates/router/src/connector/aci/transformers.rs b/crates/router/src/connector/aci/transformers.rs
index 30ed9f5d8db..7d30c80c49c 100644
--- a/crates/router/src/connector/aci/transformers.rs
+++ b/crates/router/src/connector/aci/transformers.rs
@@ -203,7 +203,9 @@ impl
bank_account_iban... | 2023-10-11T14:39:49Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [X] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Replaced payment_id with connector_request_reference_id
### ... | 550377a6c3943d9fec4ca6a8be5a5f3aafe109ab | |
juspay/hyperswitch | juspay__hyperswitch-2154 | Bug: [BUG] merchant account delete does not delete the `merchant_key_store`
### Bug Description
When a merchant is created a `merchant_key_store` is created, which goes along with the `merchant_account`. But when the merchant account is deleted, the key store is not deleted.
### Expected Behavior
Both merchant a... | diff --git a/crates/diesel_models/src/query/merchant_key_store.rs b/crates/diesel_models/src/query/merchant_key_store.rs
index 02a31a1f397..27ec3be9fcd 100644
--- a/crates/diesel_models/src/query/merchant_key_store.rs
+++ b/crates/diesel_models/src/query/merchant_key_store.rs
@@ -27,4 +27,16 @@ impl MerchantKeyStore {
... | 2023-09-26T05:34:38Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Closes #2154 by calling `delete_merchant_key_store_by_merchant_... | 54645cdbf422d59b8751fa9dbb9a61cd72770b0a | |
juspay/hyperswitch | juspay__hyperswitch-2201 | Bug: [REFACTOR]: [ACI] Remove Default Case Handling
### :memo: Feature Description
- We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector.
- These conditions generally go hand in hand with enum variant... | diff --git a/crates/router/src/connector/aci/transformers.rs b/crates/router/src/connector/aci/transformers.rs
index fe621bccd05..7fb3ba7c411 100644
--- a/crates/router/src/connector/aci/transformers.rs
+++ b/crates/router/src/connector/aci/transformers.rs
@@ -123,9 +123,32 @@ impl TryFrom<&api_models::payments::Wallet... | 2023-10-09T13:50:33Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Instead of _ case, handled each and every case explicitly.
Fix... | d82960c1cca5ae43d1a51f8fff6f7b6b9e016c2b | |
juspay/hyperswitch | juspay__hyperswitch-2153 | Bug: [FEATURE] log "MERCHANT_ID_NOT_IN_FLOW" if merchant_id is not found
### Feature Description
Here,
https://github.com/juspay/hyperswitch/blob/9b92d046de9fb794d67163582af4360d5e558037/crates/router/src/services/api.rs#L729
Instead of `unwrap_or("")`,
### Possible Implementation
Change it to some const `M... | diff --git a/crates/router/src/services/api.rs b/crates/router/src/services/api.rs
index 99400050df3..6c116e995ce 100644
--- a/crates/router/src/services/api.rs
+++ b/crates/router/src/services/api.rs
@@ -726,7 +726,10 @@ where
.authenticate_and_fetch(request.headers(), state)
.await
.switch(... | 2023-09-13T15:52:31Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
In case the merchant_id is not found from the request, instead ... | 2fc0efc57b28e987b734aba51892ab1b26e5c79b | |
juspay/hyperswitch | juspay__hyperswitch-2218 | Bug: [FEATURE]: [Authorizedotnet] Currency Unit Conversion
### :memo: Feature Description
- Each currency can be described in terms of base or minor units.
- For instance, when dealing with USD currency, the Cent is considered as the minor unit, while the Dollar is considered the base unit.
- In Hyperswitch, the ... | diff --git a/crates/router/src/connector/authorizedotnet.rs b/crates/router/src/connector/authorizedotnet.rs
index 99e87ca1edf..7ff2098344e 100644
--- a/crates/router/src/connector/authorizedotnet.rs
+++ b/crates/router/src/connector/authorizedotnet.rs
@@ -49,6 +49,10 @@ impl ConnectorCommon for Authorizedotnet {
... | 2023-10-12T19:48:15Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [X] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the API co... | fbf3c03d418242b1f5f1a15c69029023d0b25b4e | |
juspay/hyperswitch | juspay__hyperswitch-2198 | Bug: [FEATURE]: [ACI] Currency Unit Conversion
### :memo: Feature Description
- Each currency can be described in terms of base or minor units.
- For instance, when dealing with USD currency, the Cent is considered as the minor unit, while the Dollar is considered the base unit.
- In Hyperswitch, the amount value... | diff --git a/crates/router/src/connector/aci.rs b/crates/router/src/connector/aci.rs
index 0a6e0d8a609..0e325a04ddb 100644
--- a/crates/router/src/connector/aci.rs
+++ b/crates/router/src/connector/aci.rs
@@ -30,7 +30,9 @@ impl ConnectorCommon for Aci {
fn id(&self) -> &'static str {
"aci"
}
-
+ f... | 2023-10-31T17:15:03Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the API co... | 42261a5306bb99d3e20eb3aa734a895e589b1d94 | |
juspay/hyperswitch | juspay__hyperswitch-2144 | Bug: [REFACTOR] Move `Request` and `RequestBuilder` structs to common_utils crate
### Feature Description
Currently `Request` and `RequestBuilder` structs reside in router crate. Since these are common structs used while building requests for connectors, it's better to move these to `common_utils` crate. This als... | diff --git a/Cargo.lock b/Cargo.lock
index a30738c69da..082bb476dec 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -497,9 +497,9 @@ dependencies = [
[[package]]
name = "async-channel"
-version = "1.8.0"
+version = "1.9.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "cf46fee83e5ccffc22... | 2023-09-13T07:56:59Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Currently `Request` and `RequestBuilder` structs reside in rout... | bed8326597febd89bb4c961c9085a78b09f99f49 | |
juspay/hyperswitch | juspay__hyperswitch-2134 | Bug: [REFACTOR] Move `maskable` to masking crate
### Feature Description
Currently `Maskable` enum and `Mask` trait resides in router crate. Since this is related to masking we can move this to `masking` crate
### Possible Implementation
Move Maskable implementations to masking crate
### Have you spent some ti... | diff --git a/crates/masking/src/lib.rs b/crates/masking/src/lib.rs
index 8c5b03bd4f1..a0c4d3226a2 100644
--- a/crates/masking/src/lib.rs
+++ b/crates/masking/src/lib.rs
@@ -54,3 +54,7 @@ pub mod prelude {
#[cfg(feature = "diesel")]
mod diesel;
+
+pub mod maskable;
+
+pub use maskable::*;
diff --git a/crates/masking... | 2023-09-12T11:40:13Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Currently `Maskable` enum and `Mask` trait resides in router cr... | cc8847cce0022b375626b3c86e5b07048833be71 | |
juspay/hyperswitch | juspay__hyperswitch-2090 | Bug: [BUG] Add metrics in router scheduler flow as it is being ignored now
### Bug Description
Router is not maintaining any metrics about the task added in scheduler. this has to be fixed
File: crates/router/src/core/payments/helpers.rs
Method: add_domain_task_to_pt
### Expected Behavior
Metrics has to be adde... | diff --git a/crates/router/src/core/api_keys.rs b/crates/router/src/core/api_keys.rs
index c1ddc43cd65..78d4e801e8f 100644
--- a/crates/router/src/core/api_keys.rs
+++ b/crates/router/src/core/api_keys.rs
@@ -270,6 +270,11 @@ pub async fn add_api_key_expiry_task(
api_key_expiry_tracker.key_id
... | 2023-12-21T11:29:29Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
Currently `TASKS_ADDED_COUNT` and `TASKS_RESET_COUNT` metrics does not exist in router to track the tasks added in scheduler. This PR aims at adding that.
Closes #2090
## Mot... | 5ad3f8939afafce3eec39704dcaa92270b384dcd | |
juspay/hyperswitch | juspay__hyperswitch-2084 | Bug: [BUG] : [STAX] Incoming Amount is being processed as dollars instead of cents
### Bug Description
While creating a payment or a refund with connector Stax the incoming amount is being processed in it's higher decimal amount (e.g. Dollars) instead of processing it in it's lower units (e.g. Cents).
### Expe... | diff --git a/crates/router/src/connector/stax/transformers.rs b/crates/router/src/connector/stax/transformers.rs
index d4a9aebeceb..e36f66abb71 100644
--- a/crates/router/src/connector/stax/transformers.rs
+++ b/crates/router/src/connector/stax/transformers.rs
@@ -1,10 +1,12 @@
use common_utils::pii::Email;
-use error... | 2023-09-05T18:46:51Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
While creating a payment or a refund with connector Stax the in... | 99f1780fd76c7761693df1b22db9104bfa12270b | |
juspay/hyperswitch | juspay__hyperswitch-2079 | Bug: [BUG] Refunds - Retrieve is taking unexpectedly high response time
### Bug Description
This endpoint is taking quite a huge response time >~ 300 ms which shouldn't be the case.
### Expected Behavior
It should ideally take a few milliseconds. The endpoint might need to be refactored a bit to fix this.
... | diff --git a/crates/router/src/connector/bluesnap/transformers.rs b/crates/router/src/connector/bluesnap/transformers.rs
index 32455794e3f..e38a4c93420 100644
--- a/crates/router/src/connector/bluesnap/transformers.rs
+++ b/crates/router/src/connector/bluesnap/transformers.rs
@@ -939,7 +939,7 @@ impl From<ErrorDetails>... | 2023-09-04T14:08:38Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Refactoring
## Description
<!-- Describe your changes in detail -->
The connector call was being made even when `RefundStatus` was `Success` and hence the response time was going over 300ms. It will be reduced to expected now.
## Motivation... | d4221f33689b2c26b2e5753f9a3b7943811b20a3 | |
juspay/hyperswitch | juspay__hyperswitch-2039 | Bug: Implement `BusinessProfileInterface` for `MockDb`
Spin off of #172
Implement the missing implementation of MockDb for business profiles.
https://github.com/juspay/hyperswitch/blob/b8501f6ae6c0af0804d7f1e7cf9f50ebd303bf94/crates/router/src/db/business_profile.rs#L114
| diff --git a/crates/diesel_models/src/business_profile.rs b/crates/diesel_models/src/business_profile.rs
index 74c75a2bf56..23fe0aed33f 100644
--- a/crates/diesel_models/src/business_profile.rs
+++ b/crates/diesel_models/src/business_profile.rs
@@ -70,3 +70,51 @@ pub struct BusinessProfileUpdateInternal {
pub payo... | 2023-09-07T10:11:38Z | Implement the missing implementation of MockDb for business profiles.
Closes #2039
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe yo... | 517c5c41655f82ab773f6875447d7d88390d538e | |
juspay/hyperswitch | juspay__hyperswitch-1973 | Bug: [FEATURE] Use empty enums instead of unit structs for PII masking strategies
### Feature Description
Currently, we make use of unit structs that implement the `masking::Strategy<T>` trait to represent PII masking strategies. We would like to replace these with empty enums instead (So `struct MyStrategy;` bec... | diff --git a/crates/cards/src/validate.rs b/crates/cards/src/validate.rs
index db6957057ec..d083a420a1e 100644
--- a/crates/cards/src/validate.rs
+++ b/crates/cards/src/validate.rs
@@ -72,7 +72,7 @@ impl<'de> Deserialize<'de> for CardNumber {
}
}
-pub struct CardNumberStrategy;
+pub enum CardNumberStrategy {}
... | 2023-11-15T09:48:54Z | as per #1973
## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Use empty enums as strategy type parameter, instead of unit structs, to prevent instantia... | 54d6b1083fab5d2b0c7637c150524460a16a3fec | |
juspay/hyperswitch | juspay__hyperswitch-2040 | Bug: [FEATURE] Store necessary Card details in Payment methods table
### Feature Description
Will add support to add Card details in payment method table.
Currently in Payment method customers API, locker call is made for every card payment method to fetch details. Will fetch it from Payment method table instead t... | diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs
index f795513c6ef..4e67ed4d45f 100644
--- a/crates/api_models/src/payment_methods.rs
+++ b/crates/api_models/src/payment_methods.rs
@@ -144,6 +144,20 @@ pub struct PaymentMethodResponse {
pub created: Option<time::Prim... | 2023-09-01T07:55:06Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Currently, The Customer Payment method List API resorts to a lo... | 9cae5de5ffa27ce71110d703a221da65ac586d29 | |
juspay/hyperswitch | juspay__hyperswitch-1967 | Bug: [FEATURE] add fields in payments list response
### Feature Description
The `payments_list` endpoint currently has the following fields
- payment_id
- merchant_id
- status
- amount
- amount_capturable
- client_secret
- created
- currency
- description
- metadata
- order_details
- customer_id
- conn... | diff --git a/crates/router/src/core/payments/transformers.rs b/crates/router/src/core/payments/transformers.rs
index 56ff409aaf7..0765801dda8 100644
--- a/crates/router/src/core/payments/transformers.rs
+++ b/crates/router/src/core/payments/transformers.rs
@@ -708,6 +708,13 @@ impl ForeignFrom<(storage::PaymentIntent, ... | 2023-08-22T19:52:40Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
added fields
- business_label
- business_country
- business_... | 1b346fcf5649a24becff2751aa6f93d7a863ee61 | |
juspay/hyperswitch | juspay__hyperswitch-1869 | Bug: [Refactor] Suppress error while saving a card to locker after successful payment
Currently, when a payment succeeds, we save the card details to the locker. If an error occurs during this process, we return an error response, causing an inconsistency between the payment status and the card-saving status. To ens... | diff --git a/crates/router/src/core/payments/flows/authorize_flow.rs b/crates/router/src/core/payments/flows/authorize_flow.rs
index c556271a603..ddeb474548e 100644
--- a/crates/router/src/core/payments/flows/authorize_flow.rs
+++ b/crates/router/src/core/payments/flows/authorize_flow.rs
@@ -80,7 +80,7 @@ impl Feature<... | 2023-08-04T13:59:23Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Currently, when a payment succeeds, we save the card details to... | ae3d25e6899af0d78171d40c980146d58f8fc03f | |
juspay/hyperswitch | juspay__hyperswitch-1854 | Bug: [FEATURE] add requires_cvv field to customer payment method list api object
### Feature Description
We don't store the cvv in locker due to PCI compliance. Few connectors like adyen requires cvv to be collected while other connector doesn't .
### Possible Implementation
Add new field in the customer list pa... | diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs
index 248525fcc40..f795513c6ef 100644
--- a/crates/api_models/src/payment_methods.rs
+++ b/crates/api_models/src/payment_methods.rs
@@ -577,6 +577,10 @@ pub struct CustomerPaymentMethod {
#[cfg(feature = "payouts")]
... | 2023-08-02T15:07:35Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Added new field in the customer list payment method object to i... | 0d996b8960c7445289e451744c4bdeeb87d7d567 | |
juspay/hyperswitch | juspay__hyperswitch-1809 | Bug: [BUG] Diesel migration to update local database schema
### Bug Description
Apparently, a couple of migrations were skipped due to some reasons and now the DB isn't fully updated. A new diesel migration should be written to update those incomplete tables or columns.
### Possible Solution
A new diesel mi... | diff --git a/crates/diesel_models/src/schema.rs b/crates/diesel_models/src/schema.rs
index c70ad59cfd7..76c0436a79c 100644
--- a/crates/diesel_models/src/schema.rs
+++ b/crates/diesel_models/src/schema.rs
@@ -183,7 +183,7 @@ diesel::table! {
currency -> Varchar,
dispute_stage -> DisputeStage,
... | 2023-07-28T12:00:05Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
This is a part of the attempt to make database even across all environments. This PR contains the migrations for local database.
### Additional Changes
- [x] This PR modifies... | bb6ec49a66bc9380ff0f5eca44cad381b7dc4368 | |
juspay/hyperswitch | juspay__hyperswitch-2132 | Bug: [FEATURE] Add additional parameters in AppState and refactor accordingly
### Feature Description
Some additional parameters : `request_id`, `merchant_id` and `flow_name` are needed in AppState.
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and did... | diff --git a/crates/router/src/compatibility/stripe/customers.rs b/crates/router/src/compatibility/stripe/customers.rs
index f3f55418d3b..5e9a1899364 100644
--- a/crates/router/src/compatibility/stripe/customers.rs
+++ b/crates/router/src/compatibility/stripe/customers.rs
@@ -42,11 +42,11 @@ pub async fn customer_creat... | 2023-09-11T14:20:44Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] New feature
- [x] Refactoring
## Description
<!-- Describe your changes in detail -->
This PR adds additional parameters in `AppState` : `request_id` and `merchant_id` and a couple of functions in AppStateInfo : for adding `merchant_id` and f... | b39369ced97de75d26ac99230d63d3c500123005 | |
juspay/hyperswitch | juspay__hyperswitch-1793 | Bug: [BUG] Add Create Merchant and Create Merchant Key Store in a DB transaction
Currently MerchantAccount and MerchantKeyStore are getting inserted seperately. Since both of them are interdependent we need to make sure both are consistent with each other. If one of them fails other shouldn't get inserted.
We n... | diff --git a/crates/diesel_models/src/errors.rs b/crates/diesel_models/src/errors.rs
index 0a8422131ae..30e4273fdb5 100644
--- a/crates/diesel_models/src/errors.rs
+++ b/crates/diesel_models/src/errors.rs
@@ -10,7 +10,15 @@ pub enum DatabaseError {
NoFieldsToUpdate,
#[error("An error occurred when generating ... | 2023-10-22T14:35:52Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [X] Enhancement
- [X] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Merchant account creation and respective key store creation now happen in a DB transaction
### Additio... | 8e484ddab8d3f4463299c7f7e8ce75b8dd628599 | |
juspay/hyperswitch | juspay__hyperswitch-1782 | Bug: [REFACTOR] The `Drop` implementation on `RedisConnectionPool` seems unnecessary
### Description
I'll keep this issue as a source of documentation and decisions taken regarding the graceful shutdown of Redis connections.
When I was working on #1743, I noticed that the `Drop` implementation on `RedisConnect... | diff --git a/crates/redis_interface/src/lib.rs b/crates/redis_interface/src/lib.rs
index b06cc6c274f..3df54d5dc8d 100644
--- a/crates/redis_interface/src/lib.rs
+++ b/crates/redis_interface/src/lib.rs
@@ -33,7 +33,6 @@ pub use self::{commands::*, types::*};
pub struct RedisConnectionPool {
pub pool: fred::pool::R... | 2023-07-25T07:48:22Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR drops the `Drop` implementation (pun intended) on `Redi... | af9a4585b26b278ffb298d4e8de13479da447d5f | |
juspay/hyperswitch | juspay__hyperswitch-1800 | Bug: [BUG] Missing payment_method_data mappings in the helpers.rs
### Bug Description
Need to add the mappings for the latest payment methods. This would be a follow-up task for this PR : https://github.com/juspay/hyperswitch/pull/1236.
### Have you spent some time to check if this bug has been raised before?
... | diff --git a/crates/common_enums/src/enums.rs b/crates/common_enums/src/enums.rs
index ba69cedad9c..6e604c52204 100644
--- a/crates/common_enums/src/enums.rs
+++ b/crates/common_enums/src/enums.rs
@@ -954,6 +954,7 @@ pub enum PaymentMethod {
Reward,
Upi,
Voucher,
+ GiftCard,
}
#[derive(
diff --git... | 2023-07-27T09:50:46Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
This is a follow-up change for https://github.com/juspay/hyperswitch/pull/1236. This adds a `foreign_from` implementation for `payment_method_data` for the payment methods correspo... | 3da69f3ee160b022a3e2cf64c78833eb3fd95aea | |
juspay/hyperswitch | juspay__hyperswitch-1762 | Bug: [BUG] Map zip to postal_code in BillingDetails when making a PaymentsCreate request through SCL
### Bug Description
Currently the `BillingDetails` struct uses `zip` and not `postal_code`. Implement the `AddressDetails` struct for it and do the corresponding mapping to fix `deserialization error` when making ... | diff --git a/Cargo.lock b/Cargo.lock
index bb513916148..6e5967aede2 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -6146,4 +6146,4 @@ dependencies = [
"cc",
"libc",
"pkg-config",
-]
+]
\ No newline at end of file
diff --git a/crates/router/src/compatibility/stripe/payment_intents/types.rs b/crates/router/src/compati... | 2023-08-11T09:23:24Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
SCL accepts `postal_code` instead of `zip` in the `payment_method_data` field. So, this PR adds the corresponding struct changes and mappings for `BillingDetails` -> `AddressDetail... | 53de86f60d14981087626e1a2a5856089b6f3899 | |
juspay/hyperswitch | juspay__hyperswitch-1754 | Bug: [BUGFIX] Replacing the occurrences of `gen_range` with a safe alternative
## Description
Following up with the issue https://github.com/rust-random/rand/issues/1326 created by @lsampras. The function `gen_range` in itself can cause panics and error handling isn't done for some cases. This is a unpredictable ... | diff --git a/Cargo.lock b/Cargo.lock
index 50e5e015a9b..a30738c69da 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -297,6 +297,12 @@ version = "1.0.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "f26201604c87b1e01bd3d98f8d5d9a8fcbb815e8cedb41ffccbeb4bf593a35fe"
+[[package]]
+name = "adl... | 2023-09-11T20:15:56Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This is a bugfix for issue [1754](https://github.com/juspay/hyperswitch/issues/1754).
I have replaced ... | 177d8e5237241d7deea5fd911749ea0a934abcb0 | |
juspay/hyperswitch | juspay__hyperswitch-1750 | Bug: [REFACTOR]: Include Currency Conversion utility functions to `Currency` Trait implementation
### Feature Description
Implement `to_currency_base_unit` and `to_currency_base_unit_asf64` written in `router/src/utils.rs` in Currency trait implemented in `crates/common_enums/enums.rs`.
Also remove `to_currenc... | diff --git a/crates/common_enums/src/enums.rs b/crates/common_enums/src/enums.rs
index 79292641728..d3a15a83f79 100644
--- a/crates/common_enums/src/enums.rs
+++ b/crates/common_enums/src/enums.rs
@@ -1,3 +1,5 @@
+use std::num::TryFromIntError;
+
use router_derive;
use serde::{Deserialize, Serialize};
use utoipa::To... | 2023-07-25T13:40:52Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
currency conversion utility functions are converted to Currency methods
### Additional Changes
- ... | 28a371b24a590787a569f08d84149515b46ebda6 | |
juspay/hyperswitch | juspay__hyperswitch-1768 | Bug: [FEATURE] Pre-fill Required fields values in Payment Method List API
### Feature Description
1. The required fields in Payment Method List API needs to be segregated according to mandate/non-mandate payment types and a unified response should be formed for the required fields.
2. The values passed in payments... | diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs
index 749b12f77d2..0d1b3f8f9b6 100644
--- a/crates/api_models/src/payment_methods.rs
+++ b/crates/api_models/src/payment_methods.rs
@@ -1,4 +1,4 @@
-use std::collections::HashSet;
+use std::collections::HashMap;
use card... | 2023-07-31T10:46:37Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Refactored Required Fields for PM List API. It is now a HashMap... | f492d0a943ed57aadc7abed721f90ed9e19e0c88 | |
juspay/hyperswitch | juspay__hyperswitch-1697 | Bug: [FEATURE] Implement `MerchantKeyStoreInterface` for `MockDb`
### Feature Description
Currently the MerchantKeyStoreInterface is not implemented for MockDb. It is required for merchant account functions. And without this implementation, we cannot write tests for them.
### Possible Implementation
Checkout #172... | diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs
index 304e2a0fc74..caf6264db61 100644
--- a/crates/router/src/db.rs
+++ b/crates/router/src/db.rs
@@ -120,6 +120,7 @@ pub struct MockDb {
disputes: Arc<Mutex<Vec<storage::Dispute>>>,
lockers: Arc<Mutex<Vec<storage::LockerMockUp>>>,
mandates: ... | 2023-07-24T04:52:47Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR adds the `MockDb` implementation of `MerchantKeyStoreIn... | 1afc54837d5988eaf41f434474c30ec511681bbe | |
juspay/hyperswitch | juspay__hyperswitch-1649 | Bug: [BUG] Custom address struct not present in the /customers endpoints
### Bug Description
Currently the `/customers` endpoints use address as a `SecretSerdeValue` which may cause inconsistencies going on further. We need to change it to a custom struct type and populate the fields as per our API reference.
... | diff --git a/crates/api_models/src/customers.rs b/crates/api_models/src/customers.rs
index 1c28617d745..d8c864746a8 100644
--- a/crates/api_models/src/customers.rs
+++ b/crates/api_models/src/customers.rs
@@ -3,6 +3,8 @@ use masking::Secret;
use serde::{Deserialize, Serialize};
use utoipa::ToSchema;
+use crate::pay... | 2023-07-07T13:22:40Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [x] Refactoring
## Description
<!-- Describe your changes in detail -->
Address of a new customer was being accepted as a `SecretSerdeValue` in the `CustomerCreate` and `CustomerUpdate` requests. This PR does the following :
- Ad... | 5a0e8be8c4a6b112e0f0e5475c876e57802100ab | |
juspay/hyperswitch | juspay__hyperswitch-1646 | Bug: [BUG] customers endpoints refactoring in the Stripe Compatibility Layer
### Bug Description
There are a couple of mismatches and missing fields in the `/customers` endpoints in the Stripe Compatibility Layer. The corresponding match logic and structs/enums should be added to prevent the flow from breaking.
... | diff --git a/crates/api_models/src/customers.rs b/crates/api_models/src/customers.rs
index 1c28617d745..d8c864746a8 100644
--- a/crates/api_models/src/customers.rs
+++ b/crates/api_models/src/customers.rs
@@ -3,6 +3,8 @@ use masking::Secret;
use serde::{Deserialize, Serialize};
use utoipa::ToSchema;
+use crate::pay... | 2023-07-07T13:22:40Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [x] Refactoring
## Description
<!-- Describe your changes in detail -->
Address of a new customer was being accepted as a `SecretSerdeValue` in the `CustomerCreate` and `CustomerUpdate` requests. This PR does the following :
- Ad... | 5a0e8be8c4a6b112e0f0e5475c876e57802100ab | |
juspay/hyperswitch | juspay__hyperswitch-1632 | Bug: [FEATURE] Add optional fields in the PaymentsCapture Request in Stripe Compatibility Layer
### Feature Description
Currently, there's only one field present in the PaymentsCapture endpoint - `amount_to_capture`. We need to add other fields as well.
### Have you spent some time to check if this feature req... | diff --git a/crates/router/src/compatibility/stripe/payment_intents/types.rs b/crates/router/src/compatibility/stripe/payment_intents/types.rs
index de8af66214d..e06b264cef2 100644
--- a/crates/router/src/compatibility/stripe/payment_intents/types.rs
+++ b/crates/router/src/compatibility/stripe/payment_intents/types.rs... | 2023-07-06T14:25:15Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [x] New feature
## Description
<!-- Describe your changes in detail -->
This PR adds new fields, enums and structs and does the corresponding mappings wherever required.
## Motivation and Context
<!--
Why is this change required... | 5a0e8be8c4a6b112e0f0e5475c876e57802100ab | |
juspay/hyperswitch | juspay__hyperswitch-1625 | Bug: [BUG] update `api_key_expiry_workflow` to validate the expiry before scheduling the task
### Bug Description
We have a `process_tracker` which schedules the task to future date, and executes it whenever the time is up. We have a feature to schedule a reminder email to notify the merchants when their api_key ... | diff --git a/crates/router/src/core/api_keys.rs b/crates/router/src/core/api_keys.rs
index b26a67d9fe3..129b1f96e20 100644
--- a/crates/router/src/core/api_keys.rs
+++ b/crates/router/src/core/api_keys.rs
@@ -179,6 +179,7 @@ pub async fn create_api_key(
);
// Add process to process_tracker for email reminde... | 2023-07-24T12:02:29Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
During the api_key expiry if the merchant sets the expiry to next day or any other day before 7 days, we ... | b719725864c99b655956ab906e26dead71490b75 | |
juspay/hyperswitch | juspay__hyperswitch-1747 | Bug: [BUG] Internal Server Error when calling the Connector Integration
### Bug Description
Issue is caused when in any Connector `auth_type ` we configure the `auth_type` which is not valid for that particular connector gets stored in the Db. Thus , whenever we call the Connector Integration we get a 500.
Reas... | diff --git a/connector-template/mod.rs b/connector-template/mod.rs
index 653c28962b9..67745e8b4ce 100644
--- a/connector-template/mod.rs
+++ b/connector-template/mod.rs
@@ -77,6 +77,14 @@ impl ConnectorCommon for {{project-name | downcase | pascal_case}} {
fn base_url<'a>(&self, connectors: &'a settings::Connector... | 2023-07-19T09:48:48Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Issue is caused when in any Connector 's `auth_type` we configure the invalid `auth_type` for that pa... | 7f947169feac9d15616cc2b1a2aacdfa80f219bf | |
juspay/hyperswitch | juspay__hyperswitch-1616 | Bug: [BUG] Map zip field in address enum to match postal_code as per Stripe API Reference
### Bug Description
Currently the `zip` field in the `address` enum is being passed as `zip` itself. But, according to the Stripe API Reference it needs to be passed as `postal_code`. So, appropriate mapping should be done.
... | diff --git a/crates/router/src/compatibility/stripe/payment_intents/types.rs b/crates/router/src/compatibility/stripe/payment_intents/types.rs
index de8af66214d..e06b264cef2 100644
--- a/crates/router/src/compatibility/stripe/payment_intents/types.rs
+++ b/crates/router/src/compatibility/stripe/payment_intents/types.rs... | 2023-07-06T14:25:15Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [x] New feature
## Description
<!-- Describe your changes in detail -->
This PR adds new fields, enums and structs and does the corresponding mappings wherever required.
## Motivation and Context
<!--
Why is this change required... | 5a0e8be8c4a6b112e0f0e5475c876e57802100ab | |
juspay/hyperswitch | juspay__hyperswitch-1618 | Bug: [BUG] mandate_data is being passed in Response but not in Request while creating/updating/confirming payment intents
### Bug Description
The field `mandate_data` is being populated while processing the request but it's not a request body parameter itself. Add it as a request body parameter in `StripePaymentI... | diff --git a/crates/router/src/compatibility/stripe/payment_intents/types.rs b/crates/router/src/compatibility/stripe/payment_intents/types.rs
index de8af66214d..e06b264cef2 100644
--- a/crates/router/src/compatibility/stripe/payment_intents/types.rs
+++ b/crates/router/src/compatibility/stripe/payment_intents/types.rs... | 2023-07-06T14:25:15Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [x] New feature
## Description
<!-- Describe your changes in detail -->
This PR adds new fields, enums and structs and does the corresponding mappings wherever required.
## Motivation and Context
<!--
Why is this change required... | 5a0e8be8c4a6b112e0f0e5475c876e57802100ab | |
juspay/hyperswitch | juspay__hyperswitch-1615 | Bug: [BUG] Rename fields in Stripe Compatibility Layer as per Stripe API Reference
### Bug Description
The following fields are named incorrectly in the `Stripe Compatibility Layer` :
- Named as `payment_method_type` -> Should be `payment_method_types`
- Named as `mandate_id` -> Should be `mandate`
They n... | diff --git a/crates/router/src/compatibility/stripe/payment_intents/types.rs b/crates/router/src/compatibility/stripe/payment_intents/types.rs
index de8af66214d..e06b264cef2 100644
--- a/crates/router/src/compatibility/stripe/payment_intents/types.rs
+++ b/crates/router/src/compatibility/stripe/payment_intents/types.rs... | 2023-07-06T14:25:15Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [x] New feature
## Description
<!-- Describe your changes in detail -->
This PR adds new fields, enums and structs and does the corresponding mappings wherever required.
## Motivation and Context
<!--
Why is this change required... | 5a0e8be8c4a6b112e0f0e5475c876e57802100ab | |
juspay/hyperswitch | juspay__hyperswitch-1580 | Bug: [enhancement]:Add scoped error enum for customer error
tracked in #1579
We wanna use scoped errors + Errorswitch for customer API's
Currently customer API's returns the common errors enum...
It uses
```
CustomerRedacted
CustomerNotFound
MandateNotFound
& a lot of InternalServerError's
```
inst... | diff --git a/crates/router/src/compatibility/stripe/customers.rs b/crates/router/src/compatibility/stripe/customers.rs
index 0a2cc27f376..f3f55418d3b 100644
--- a/crates/router/src/compatibility/stripe/customers.rs
+++ b/crates/router/src/compatibility/stripe/customers.rs
@@ -39,6 +39,7 @@ pub async fn customer_create(... | 2023-08-22T20:29:32Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Have customers api endpoint specific error logging
### Additional Changes
- [ ] This PR modifies t... | 576648b5a5d7775d295479df3438c913ae855827 | |
juspay/hyperswitch | juspay__hyperswitch-1578 | Bug: [FEATURE] Implement a masking strategy for UPI VPAs
### Feature Description
Unified Payments Interface (UPI) is a popular payment technique in India, used to transfer money among individuals, bill payments and merchant payments. In the case of money transfer among individuals, users are identified with a Vir... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index 6e489ac492a..a184382e654 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -922,7 +922,7 @@ pub struct CryptoData {
#[serde(rename_all = "snake_case")]
pub struct UpiData {
#[schema(va... | 2023-07-06T15:33:58Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Here, I have implemented masking::Strategy for UPI VPAs which i... | 9c7ac6246d6cf434855bc61f7cd625101665de5c | |
juspay/hyperswitch | juspay__hyperswitch-1741 | Bug: [BUG] Internal Server Error when deleting a payment method
### Bug Description
It bugs out when you try to delete a payment method that you created by throwing a 500.
Reason: We're not storing the payment_method_data in `configs` table but only in the database. The present code tries to delete it from the `... | diff --git a/Cargo.lock b/Cargo.lock
index e42e38db862..f93aa8d1dc8 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1858,9 +1858,9 @@ dependencies = [
[[package]]
name = "equivalent"
-version = "1.0.0"
+version = "1.0.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "88bffebc5d80432c9b1... | 2023-07-12T16:14:18Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
- When a payment is done through saved card flow, the details is stored in Vault. To delete this, we need to pass `payment_method_id`. Since the `payment_method_id` is **not** expo... | 53ccde80467c6b6037b3a0c372aa879d9867571b | |
juspay/hyperswitch | juspay__hyperswitch-1613 | Bug: [FEATURE] add connector_metadata, metadata and feature_metadata fields in payments, remove udf field
### Feature Description
Add connector_metadata, metadata and feature_metadata fields in payments, remove udf field
### Possible Implementation
Add them
### Have you spent some time to check if this featur... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index e2410699e1c..1f7b3050430 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -3,6 +3,7 @@ use std::num::NonZeroI64;
use cards::CardNumber;
use common_utils::{
crypto,
+ ext_traits::En... | 2023-07-03T08:07:28Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
In this PR ,
#### API CONTRACT CHANGES
In `PaymentsRequest` ... | 737aeb6b0a083bdbcde169d4cfeb40ebc6f4378e | |
juspay/hyperswitch | juspay__hyperswitch-1550 | Bug: [REFACTOR] add `payment_id` and `merchant_id` to logs
The `server_wrap_util()` function will have to record the `merchant_id` as the authentication will happen inside `server_wrap()` function, so that the `payment_id` and `merchant_id` fields are available in the logs. | diff --git a/crates/router/src/services/api.rs b/crates/router/src/services/api.rs
index c8d69d7d51c..353d508c285 100644
--- a/crates/router/src/services/api.rs
+++ b/crates/router/src/services/api.rs
@@ -581,7 +581,7 @@ pub enum AuthFlow {
Merchant,
}
-#[instrument(skip(request, payload, state, func, api_auth)... | 2023-06-27T07:54:32Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Refactoring
## Description
<!-- Describe your changes in detail -->
- This PR includes minor changes to support adding payment id in the `Payments` flow logs. These changes will be used in other crates.
- Record `merchant_id` field in `server... | a899c9738941fd1a34841369c9a13b2ac49dda9c | |
juspay/hyperswitch | juspay__hyperswitch-1593 | Bug: feat(CI/CD):Implement Code Cov for CI checks
Tracked in #1587
Implement Code coverage for PR's via CI
Objectives
- run tests as part of CI
- generate codeCov for these tests & auto-publish the report as part of PR Comment...
- [Optionally] be able to specify that atleast x% of new code should be test-co... | diff --git a/.gitignore b/.gitignore
index dcbeddf7ada..d53145b33ee 100644
--- a/.gitignore
+++ b/.gitignore
@@ -241,6 +241,7 @@ $RECYCLE.BIN/
# hyperswitch Project specific excludes
# code coverage report
*.profraw
+lcov.info
html/
coverage.json
# other
diff --git a/README.md b/README.md
index c09176b172a..5b551... | 2024-12-19T06:36:46Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
Added a CI pipeline that will run cypress tests and generate co... | 90c932a6d798453f7e828c55a7668c5c64c933a5 | |
juspay/hyperswitch | juspay__hyperswitch-1587 | Bug: [FEATURE]: setup code coverage for local tests & CI
#### Context
As any other codebase, unit tests are vital to maintain stability & correctness of code..
Currently while the project has some amount of tests, We still don't have a code coverage tracking in place which robs people of some of the incentives f... | diff --git a/.gitignore b/.gitignore
index dcbeddf7ada..d53145b33ee 100644
--- a/.gitignore
+++ b/.gitignore
@@ -241,6 +241,7 @@ $RECYCLE.BIN/
# hyperswitch Project specific excludes
# code coverage report
*.profraw
+lcov.info
html/
coverage.json
# other
diff --git a/README.md b/README.md
index c09176b172a..5b551... | 2024-12-19T06:36:46Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
Added a CI pipeline that will run cypress tests and generate co... | 90c932a6d798453f7e828c55a7668c5c64c933a5 | |
juspay/hyperswitch | juspay__hyperswitch-1541 | Bug: [BUG] `payment_method_id` is not being stored in `payment_methods` table
### Bug Description
`payment_mehod_id` that is created at the time of creating a PaymentMethod is not being stored in `payment_methods` table. This results in database error showing 404 during update and 500 when trying to delete `payment... | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index 5020c877bae..8d7c228df4a 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -86,20 +86,26 @@ pub async fn add_payment_method(
let m... | 2023-07-07T12:34:17Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Currently, payment method create API does not insert payment me... | 55ff761e9eca313327f67c1d271ea1672d12c339 | |
juspay/hyperswitch | juspay__hyperswitch-1573 | Bug: [FEATURE] Use OS specific profile path in selenium tests
### Feature Description
Currently the default profile path for browser in selenium.rs file is hardcoded with mac specific file path. it should be made OS specific instead of hardcoding.
### Possible Implementation
Add a feature for OS and handle the p... | diff --git a/.gitignore b/.gitignore
index 81ef10ad213..62804a712fa 100644
--- a/.gitignore
+++ b/.gitignore
@@ -261,3 +261,7 @@ result*
# node_modules
node_modules/
+
+**/connector_auth.toml
+**/sample_auth.toml
+**/auth.toml
diff --git a/crates/test_utils/tests/connectors/adyen_uk_ui.rs b/crates/test_utils/tests/... | 2023-09-17T06:30:00Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Enhancement
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR aims at automating Googlepay tests in UI Tests for connectors: Adyen_UK, Bluesnap and Stripe.
Main problem with Google Pay UI automated testing is Capt... | 67a3e8f534aa98a7331cb20a3877579efed6a348 | |
juspay/hyperswitch | juspay__hyperswitch-1532 | Bug: [BUG] "mandate_data" returned as null in the PaymentsCreate response body while creating a new mandate payment
### Bug Description
While creating a new mandate payment, the `mandate_data` field is being returned as **null** in the response body. This occurs even after passing the right `mandate_data` content... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index a49a8f00fa8..58652009b27 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -1422,6 +1422,7 @@ pub struct PaymentsResponse {
pub mandate_id: Option<String>,
/// Provided mandate in... | 2023-07-14T11:23:44Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
Earlier `mandate_data` was being returned as `null`. This PR fixes the same and populates `mandate_data` with the same content as sent in the request body.
## Motivation and Con... | c9e20dcd30beb1de0b571dc61a0e843eda3f8ae0 | |
juspay/hyperswitch | juspay__hyperswitch-1523 | Bug: [BUG] "reason" field not being updated while hitting the Refunds - Update endpoint
### Bug Description
Upon hitting the `Refunds - Update` endpoint, we receive a 200 OK response but the `reason` field is not being updated.
### Expected Behavior
The `reason` field should be updated as per the specified ... | diff --git a/crates/diesel_models/src/refund.rs b/crates/diesel_models/src/refund.rs
index b0b1f03f200..595d54ea7f4 100644
--- a/crates/diesel_models/src/refund.rs
+++ b/crates/diesel_models/src/refund.rs
@@ -190,6 +190,7 @@ impl RefundUpdate {
refund_error_code: pa_update.refund_error_code.or(source.refun... | 2023-06-26T09:49:45Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
The `reason` field is incorrectly mapped in the core logic so this PR modifies that. Also, the `refund_reason` field is missing in the db update function so this PR adds that.
#... | 16a2c46affbd4319ee1106e08922e7f3094adfbe | |
juspay/hyperswitch | juspay__hyperswitch-1512 | Bug: [BUG] Validate and update 4xx in Files - Delete endpoint
### Bug Description
The following error is being thrown with a 400 error code when we're hitting the Files - Delete endpoint :
`"error": {
"type": "invalid_request",
"message": "Payment method type not supported",
"code":... | diff --git a/crates/router/src/compatibility/stripe/errors.rs b/crates/router/src/compatibility/stripe/errors.rs
index 7e341f071d2..c056b454a6c 100644
--- a/crates/router/src/compatibility/stripe/errors.rs
+++ b/crates/router/src/compatibility/stripe/errors.rs
@@ -202,6 +202,8 @@ pub enum StripeErrorCode {
FileNot... | 2023-06-23T12:55:57Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
Introduced new error `FileProviderNotSupported` and fixed the error mapping for the `Files - Delete` endpoint thrown when the file storage is not `router`.
## Motivation and Con... | 9a88a32d5092cdacacc41bc8ec12ff56d4f53adf | |
juspay/hyperswitch | juspay__hyperswitch-1513 | Bug: [BUG] API Handler missing for Disputes - Retrieve Evidence endpoint
### Bug Description
API Handler is missing (got removed somehow) for the `Disputes - Retrieve Evidence` endpoint. This results in a Content Not Found error (404).
### Expected Behavior
The endpoint is implemented and working fine. It s... | diff --git a/crates/router/src/routes/app.rs b/crates/router/src/routes/app.rs
index f153850ce87..35e366ac6f3 100644
--- a/crates/router/src/routes/app.rs
+++ b/crates/router/src/routes/app.rs
@@ -464,6 +464,10 @@ impl Disputes {
.route(web::post().to(submit_dispute_evidence))
... | 2023-06-22T13:23:28Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
This PR adds the missing API Handler for the mentioned endpoint.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open ... | ff17b62dc27092b6e04d19604e02e8f492c19efb | |
juspay/hyperswitch | juspay__hyperswitch-1522 | Bug: [BUG] Braintree throws payment status as succeeded while it is still processing the payment
### Bug Description
When you make a payment through Braintree, it directly gives the payment status as succeeded instead of Processing since `SubmittedForSettlement` has to be mapped to `Pending` instead of `Charged`. ... | diff --git a/crates/router/src/connector/braintree/transformers.rs b/crates/router/src/connector/braintree/transformers.rs
index b5e81097ca1..ce1fa2262ad 100644
--- a/crates/router/src/connector/braintree/transformers.rs
+++ b/crates/router/src/connector/braintree/transformers.rs
@@ -184,9 +184,7 @@ pub enum BraintreeP... | 2023-06-22T11:16:20Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
`SubmittedForSettlement` in Braintree is set to `Pending` since it `SubmittedForSettlement` changes is a nightly process and takes time to finish the payment. Docs attached below:
... | 69e9e518f40c4267c1d58b455b83088e431f767f | |
juspay/hyperswitch | juspay__hyperswitch-1495 | Bug: [BUG] : Bank Transfer status mapping is wrong for stripe
### Bug Description
While making the payment for bank transfer its going to "processing" state instead of "requires_customer_action".
Even after payment sync also its in processing state.
### Expected Behavior
It should be in "requires_customer_action... | diff --git a/crates/router/src/connector/trustpay/transformers.rs b/crates/router/src/connector/trustpay/transformers.rs
index e93c0358b80..ffb84059f11 100644
--- a/crates/router/src/connector/trustpay/transformers.rs
+++ b/crates/router/src/connector/trustpay/transformers.rs
@@ -950,6 +950,7 @@ impl<F, T>
... | 2023-06-21T11:54:15Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
The status of `router_data` was being updated after update trackers to `processing`. But in case of Bank transfers, the status of payment is updated in pre processing steps, so we ... | 6645c4d123399e2b6615c02932adf4571b8bcd91 | |
juspay/hyperswitch | juspay__hyperswitch-1497 | Bug: [BUG] Make get_redis_conn return result in StorageInterface
### Bug Description
Currently `get_redis_conn` function in StorageInterface exposes `redis_conn` directly instead use `redis_conn()` function from `Store` and return Result in this function.
### Expected Behavior
It should return err in case of redi... | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index 67f498c1e99..00a647ed5c9 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -1713,7 +1713,12 @@ pub async fn list_customer_payment_metho... | 2023-06-27T11:38:55Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [X] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Fixes #1497
## Motivation and Context
Please find the details in the issue [1497](https://github.com... | 8186c778bddb8932b37e5cf4c7b3e2d507f73e89 | |
juspay/hyperswitch | juspay__hyperswitch-1475 | Bug: [BUG] PSync does not change the payment status for NMI connector
### Bug Description
It bugs out when you do a payment and make a PSync call. For context, NMI requires you to do a PSync to update the payment status every time you make a payment. Now that, with PSync flow not updating the payment status after d... | diff --git a/crates/router/src/connector/nmi/transformers.rs b/crates/router/src/connector/nmi/transformers.rs
index eb09497cede..a99c1c9f4ba 100644
--- a/crates/router/src/connector/nmi/transformers.rs
+++ b/crates/router/src/connector/nmi/transformers.rs
@@ -510,8 +510,7 @@ impl From<NmiStatus> for enums::AttemptStat... | 2023-06-19T05:05:31Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
This PR aims at fixing the PSync flow for NMI connector that used to keep the payment status as Pending even after doing the PSync call. FYI, NMI requires you to do a PSync call ev... | 17640858eabb5d5a56a17c9e0a52e5773a0c592f | |
juspay/hyperswitch | juspay__hyperswitch-1491 | Bug: Implement `PaymentMethodInterface` for `MockDb`
Spin out from https://github.com/juspay/hyperswitch/issues/172. Please refer to that issue for more information. | diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs
index 3cd510b33e5..378298727a8 100644
--- a/crates/router/src/db.rs
+++ b/crates/router/src/db.rs
@@ -102,6 +102,7 @@ pub struct MockDb {
merchant_connector_accounts: Arc<Mutex<Vec<storage::MerchantConnectorAccount>>>,
payment_attempts: Arc<Mutex<... | 2023-06-23T14:26:37Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the API co... | e296a49b623004784cece505ab08b172a5aa796c | |
juspay/hyperswitch | juspay__hyperswitch-1471 | Bug: [BUG] payment status is processing if there is a validation error
### Bug Description
The payment flow is as follows
- Merchant server creates the Payments with amount and currency and other merchant specific fields.
- The SDK confirms the payment with `PaymentMethodData`.
During confirm, the connector ... | diff --git a/crates/router/src/connector/airwallex.rs b/crates/router/src/connector/airwallex.rs
index 2c4915c40c8..1a95f670426 100644
--- a/crates/router/src/connector/airwallex.rs
+++ b/crates/router/src/connector/airwallex.rs
@@ -308,6 +308,7 @@ impl ConnectorIntegration<api::Authorize, types::PaymentsAuthorizeData,... | 2023-06-18T05:17:48Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Refactoring
## Description
<!-- Describe your changes in detail -->
Update trackers has been moved before callling the connector. This is to make sure that if there is any validation error, then the payment status will not be updated.
For ot... | 8032e0290b0a0ee33a640740b3bd4567a939712c | |
juspay/hyperswitch | juspay__hyperswitch-1464 | Bug: [BUG] Adyen payment status update for Manual Capture payment
### Bug Description
We have to rely on web hooks for status update for manual capture payment. But the problem is in both Auto And Manual capture flow we will receive `Authorized` event web hook, additionally in manual capture we will get one more... | diff --git a/crates/router/src/connector/adyen.rs b/crates/router/src/connector/adyen.rs
index 93301364e62..67e319ddc22 100644
--- a/crates/router/src/connector/adyen.rs
+++ b/crates/router/src/connector/adyen.rs
@@ -403,6 +403,13 @@ impl
) -> CustomResult<types::ErrorResponse, errors::ConnectorError> {
s... | 2024-03-06T09:30:25Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [X] Bugfix
- [ ] New feature
- [ ] Enhancement
- [X] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- Update Psync response handler to consume the incoming webhook... | a1fd36a1abea4d400386a00ccf182dfe9da5bcda | |
juspay/hyperswitch | juspay__hyperswitch-1425 | Bug: [BUG] Prevent unwarranted 404 responses for `CustomerPaymentMethodsList` endpoint
`CustomerPaymentMethodsList` currently lists all the saved payment methods for a customer,
However if the customer doesn't have any saved method we end up returning 404...
We should instead return an empty array when the cus... | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index 499056aa4e5..a5a5c0917fa 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -1562,6 +1562,10 @@ pub async fn list_customer_payment_metho... | 2023-06-13T14:58:56Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This pull request updates the `list_customer_payment_method` fu... | ec2bf2160d9139776672614dfdc5201f17cdef05 | |
juspay/hyperswitch | juspay__hyperswitch-1439 | Bug: [BUG] Payments list doesn't work with pagination parameters
### Context
- Currently the API accepts payment_id as pagination parameters for e.g starting_after = `pay_Ajabdhakjhah`
- However the underlying code relies on the auto-increment characteristic of databases
- While we do some sort of conversion here... | diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs
index 384a2230389..c9bc3d0a649 100644
--- a/crates/router/src/core/payments.rs
+++ b/crates/router/src/core/payments.rs
@@ -1204,8 +1204,6 @@ pub async fn list_payments(
merchant: domain::MerchantAccount,
constraints: api::Pa... | 2023-06-28T02:17:37Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Sorted the payment list order in API response for descending based on `created_at` parameter. It allows t... | 06f92c2c4c267e3d6ec914670684bb36b71ecd51 | |
juspay/hyperswitch | juspay__hyperswitch-1446 | Bug: [REFACTOR] accept customer details in customer object
Currently, for a payment, the `CustomerDetails` such as email, phone, name are accepted in the `PaymentsRequest` struct
https://github.com/juspay/hyperswitch/blob/795500797d1061630b5ca493187a4e19d98d26c0/crates/api_models/src/payments.rs#L59
It is not c... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index 173b795efa3..53ce196737a 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -45,6 +45,28 @@ pub struct BankCodeResponse {
pub eligible_connectors: Vec<String>,
}
+#[derive(Default, Deb... | 2023-06-15T09:12:56Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
This PR will support sending the customer details in the `customers` object in `PaymentsRequest` in all three endpoints
- payments-create
- payments-update
- payments-confirm
... | a7ac4af5d916ff1e7965be35f347ce0e13407747 | |
juspay/hyperswitch | juspay__hyperswitch-1374 | Bug: [BUG] `payment_method_type` not set in the payment attempt when making a recurring mandate payment
### Bug Description
When doing a recurring mandate payment, the `payment_method` is set in the newly created payment attempt but the `payment_method_type` is not set.
### Expected Behavior
When fetching t... | diff --git a/crates/router/src/core/payments/helpers.rs b/crates/router/src/core/payments/helpers.rs
index 6d6017f6f81..cee33730706 100644
--- a/crates/router/src/core/payments/helpers.rs
+++ b/crates/router/src/core/payments/helpers.rs
@@ -272,6 +272,7 @@ pub async fn get_token_pm_type_mandate_details(
) -> RouterRes... | 2023-06-12T12:26:28Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
When doing a recurring mandate payment, the `payment_method` is set in the newly created payment attempt but the `payment_method_type` is not set. This PR aims to fix that.
**[#... | 17640858eabb5d5a56a17c9e0a52e5773a0c592f | |
juspay/hyperswitch | juspay__hyperswitch-1373 | Bug: [BUG] Certificate decode failed when creating the session token for `applepay`
### Bug Description
It bugs out when creating session token for `applepay` if the certificate provided is in the wrong format.
### Expected Behavior
If the certificate provided is in the wrong format, then it should error out duri... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index 83be6c85c3f..96b5e3f29b4 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -1713,6 +1713,12 @@ pub struct ApplepaySessionRequest {
pub initiative_context: String,
}
+#[derive(Debug, C... | 2023-06-08T07:04:43Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
We used to have a lot of errors when creating applepay session tokens because of invalid certificates being sent when creating the merchant connector account.
This PR will not ... | d0d32544c23481a1acd91182055a7a0afb78d723 | |
juspay/hyperswitch | juspay__hyperswitch-1365 | Bug: [BUG] `payment_method_type` not saved when creating a record in the `payment_method` table
### Bug Description
When saving the payment method record to the `payment_method` table after a payment, only the `PaymentMethod` is saved but not the `PaymentMethodType` even if it is present in the request.
### Expect... | diff --git a/crates/router/src/core/payments/flows/authorize_flow.rs b/crates/router/src/core/payments/flows/authorize_flow.rs
index 49d30f6e87e..36d40d7480e 100644
--- a/crates/router/src/core/payments/flows/authorize_flow.rs
+++ b/crates/router/src/core/payments/flows/authorize_flow.rs
@@ -84,6 +84,7 @@ impl Feature<... | 2023-06-07T10:27:25Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
When saving the payment method record to the payment_method table after a payment, only the PaymentMethod is saved but not the PaymentMethodType even if it is present in the reques... | 5eb033336321b5deb197f4416c8409abf99a8421 | |
juspay/hyperswitch | juspay__hyperswitch-1357 | Bug: [FEATURE] add domain type for client secret
### Feature Description
Create domain type for client secret
### Possible Implementation
Make type `ClietSecret(String)` and use it wherever applicable
### Have you spent some time to check if this feature request has been raised before?
- [X] I checked and didn... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index 6bccfd1124c..1be9762c76c 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -1,4 +1,4 @@
-use std::num::NonZeroI64;
+use std::{fmt, num::NonZeroI64};
use cards::CardNumber;
use common_util... | 2024-02-05T22:29:45Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Implement `ClientSecret` type for payments.
Closes #1357
### Additional Changes
- [ ] This P... | 91cd70a60b89b1c4e868e359a75f4088854562ef | |
juspay/hyperswitch | juspay__hyperswitch-1353 | Bug: [REFACTOR] Unify the `sandbox` and `production` cargo features
### Description
After #1349, this is the next step towards using a single Docker image across all our environments (see #1346). The `sandbox` and `production` features would have to be unified into a single `release` feature instead. This change ... | diff --git a/Dockerfile b/Dockerfile
index 2805ee18325..fb92bd3acb5 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,6 +1,5 @@
FROM rust:slim as builder
-ARG RUN_ENV=sandbox
ARG EXTRA_FEATURES=""
RUN apt-get update \
@@ -33,7 +32,7 @@ ENV RUST_BACKTRACE="short"
ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL="sparse"
... | 2023-06-06T10:43:57Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR unifies the `sandbox` and `production` cargo features i... | 1322aa757902662a1bd90cc3f09e887a7fdbf841 | |
juspay/hyperswitch | juspay__hyperswitch-1354 | Bug: [FEATURE] Inclusion of Customer_ip field for PaymentConfirm flows
### Feature Description
Need to derive Ip_addr of the customer from the headers(x-forwarded-for) to the request.
### Possible Implementation
Creation of customer_ip field in PaymentData and then lower the stuffs down to the PaymentConfirm.
##... | diff --git a/crates/router/src/connector/adyen/transformers.rs b/crates/router/src/connector/adyen/transformers.rs
index ffd4a57db57..e57e13167d8 100644
--- a/crates/router/src/connector/adyen/transformers.rs
+++ b/crates/router/src/connector/adyen/transformers.rs
@@ -1,5 +1,6 @@
use api_models::{enums, payments, webh... | 2023-06-06T15:42:58Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Addition of customer_ip field to be taken from either x-forwarded-for or from request itself.
### Ad... | 795500797d1061630b5ca493187a4e19d98d26c0 | |
juspay/hyperswitch | juspay__hyperswitch-1327 | Bug: [REFACTOR] remove redundant call to fetch payment method data
In case of `payments_start` operation, there is a call to fetch payment method data ( which makes a call to the locker to fetch payment method data ). This call is not necessary since we do not need payment method data in that flow. This would add ad... | diff --git a/crates/router/src/core/payments/operations/payment_start.rs b/crates/router/src/core/payments/operations/payment_start.rs
index 5cd2d11c081..2e2904d9746 100644
--- a/crates/router/src/core/payments/operations/payment_start.rs
+++ b/crates/router/src/core/payments/operations/payment_start.rs
@@ -241,14 +241... | 2023-06-30T13:59:55Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This pull request removes the unnecessary call to fetch payment... | 88860b9c0be0bc91bcdd6f89b60eb43a18b83b08 | |
juspay/hyperswitch | juspay__hyperswitch-1335 | Bug: [BUG] unnecessary assertions for `locker_id` on `BasiliskLocker` when saving cards
Currently we support 2 types of lockers for saving cards...
1. BasiliskLocker
2. LegacyLocker
We used to have locker_id as a namespacing identifier for merchants, however that concept is deprecated now with the BasiliskLock... | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index cba6aef7302..499056aa4e5 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -262,12 +262,6 @@ pub async fn add_card_hs(
let db = &*... | 2023-06-02T07:30:10Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
We used to have locker_id as a namespacing identifier for merch... | b681f78d964d02f80249751cc6fd12e3c85bc4d7 | |
juspay/hyperswitch | juspay__hyperswitch-1326 | Bug: [REFACTOR] Define the Mapping between `ConnectorError` and `ApiErrorResponse` using the `ErrorSwitch` trait
### Feature Description
Currently, we are mapping errors from `ConnectorError` to `ApiErrorResponse` using custom logic (can be found [here](https://github.com/juspay/hyperswitch/blob/cd0cf40fe29358700f9... | diff --git a/crates/router/src/core/errors.rs b/crates/router/src/core/errors.rs
index d79e120c5c0..2ab8aff3a0a 100644
--- a/crates/router/src/core/errors.rs
+++ b/crates/router/src/core/errors.rs
@@ -1,5 +1,6 @@
pub mod api_error_response;
pub mod error_handlers;
+pub mod transformers;
pub mod utils;
use std::fm... | 2023-07-08T17:49:30Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the API co... | fb149cb0ff750fbaadf22d263be0f7bfe1574e37 | |
juspay/hyperswitch | juspay__hyperswitch-1325 | Bug: [BUG] Missing required field `email` during payments_confirm
### Bug Description
It bugs out when a payment is created with the `email` field and then not passing it when confirming the payment.
### Expected Behavior
The confirm payment should succeed, it should take the email which was supplied during the p... | diff --git a/crates/router/src/core/payments/helpers.rs b/crates/router/src/core/payments/helpers.rs
index 3147ef8026b..fb0454da425 100644
--- a/crates/router/src/core/payments/helpers.rs
+++ b/crates/router/src/core/payments/helpers.rs
@@ -35,7 +35,7 @@ use crate::{
self,
types::{self, AsyncL... | 2023-06-09T11:56:11Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
This PR will update the customer details in payment, when sent in the payments request.
## Motivation and Context
<!--
Why is this change required? What problem does it solv... | 8497c55283d548c04b3a01560b06d9594e7d634c | |
juspay/hyperswitch | juspay__hyperswitch-1314 | Bug: [FEATURE] Adding recon dashboard in hyperswitch dashboard
### Feature Description
*
### Possible Implementation
*
### Have you spent some time to check if this feature request has been raised before?
- [X] I checked and didn't find similar issue
### Have you read the Contributing Guidelines?
- [X] I have... | diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs
index 9868d963fe6..7a6e984776e 100644
--- a/crates/api_models/src/admin.rs
+++ b/crates/api_models/src/admin.rs
@@ -227,6 +227,9 @@ pub struct MerchantAccountResponse {
/// The organization id merchant is associated with
pub organi... | 2023-07-14T10:36:46Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Added is_recon_enabled field in merchant_account table and sending it in retrive merchant_account api
... | 432a8e02e98494bd20bcb8c2a1a425f9504b86c7 | |
juspay/hyperswitch | juspay__hyperswitch-1312 | Bug: [BUG] Adyen throws `500` when doing PSync call for non-redirection flow
### Bug Description
Adyen throws `500` when doing PSync call for non-redirection flow.
### Expected Behavior
Since Adyen doesn't PSync for normal non-redirection flow, it should tell user that PSync is not supported instead of throwing ... | diff --git a/crates/router/src/connector/adyen.rs b/crates/router/src/connector/adyen.rs
index 380a96c6b57..149beb97c65 100644
--- a/crates/router/src/connector/adyen.rs
+++ b/crates/router/src/connector/adyen.rs
@@ -310,12 +310,19 @@ impl
&self,
req: &types::RouterData<api::PSync, types::PaymentsSync... | 2023-05-29T17:43:22Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
## Description
<!-- Describe your changes in detail -->
This PR address Internal Server Error that arised when calling PSync in non-redirection flow.
`contains_encoded_data` in the else part is needed if not, status about the payments ... | 10691c5fce630d60aade862080d25c62a5cddb44 | |
juspay/hyperswitch | juspay__hyperswitch-1309 | Bug: feat(connector): [Shift4] Refund webhooks
Refund webhook support for connector shift4 | diff --git a/crates/router/src/connector/shift4.rs b/crates/router/src/connector/shift4.rs
index 8f8d6cee56b..d75a0896583 100644
--- a/crates/router/src/connector/shift4.rs
+++ b/crates/router/src/connector/shift4.rs
@@ -3,7 +3,7 @@ mod transformers;
use std::fmt::Debug;
use common_utils::ext_traits::ByteSliceExt;
... | 2023-05-29T14:52:30Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Refund webhook support for shift4 ([status mapping ref](https:/... | 4a8de7741d43da07e655bc7382927c68e8ac1eb5 | |
juspay/hyperswitch | juspay__hyperswitch-1349 | Bug: [REFACTOR] Remove the `pii-encryption-script` cargo feature
### Description
As of now, the `sandbox` and `production` cargo features differ only by the `pii-encryption-script` cargo feature:
https://github.com/juspay/hyperswitch/blob/fc6acd04cb28f02a4f52ec77d8ae003957183ff2/crates/router/Cargo.toml#L19-L2... | diff --git a/config/config.example.toml b/config/config.example.toml
index 28113bfb3cd..645908ee8d9 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -101,7 +101,6 @@ admin_api_key = "test_admin" # admin API key for admin authentication. Only
kms_encrypted_admin_api_key = "" # Base64-enco... | 2023-06-05T10:20:44Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR removes the `pii-encryption-script` cargo feature from ... | ba8a17d66f12fce01fa3a2d50bd9a5591bf8ef2f | |
juspay/hyperswitch | juspay__hyperswitch-1348 | Bug: [REFACTOR] Use secrets for sensitive data handled in connector integration
Noticed that this file didn't include changes related to masking of API keys.
Should we take up marking this field (and wherever it's being passed) `Secret` as part of this PR, or a separate one?
https://github.com/ju... | diff --git a/connector-template/transformers.rs b/connector-template/transformers.rs
index d76b63a1f31..ac51bb5e38d 100644
--- a/connector-template/transformers.rs
+++ b/connector-template/transformers.rs
@@ -53,7 +53,7 @@ impl TryFrom<&types::ConnectorAuthType> for {{project-name | downcase | pascal_c
fn try_from... | 2023-06-14T14:47:56Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR addresses an issue related to handling sensitive data i... | 9e2868ccf86854135a6f0668985d92fae72e82ed | |
juspay/hyperswitch | juspay__hyperswitch-1293 | Bug: [PERF] Remove redundant heap allocation present in the logging framework
Use here, below, and in similar places, the`format_args!()` macro instead, to omit redundant allocations produced by the `format!()` macro (as it returns a new `String`).
## Code Snippets
- https://github.com/juspay/hyperswitch/blob/... | diff --git a/crates/router_env/src/logger/formatter.rs b/crates/router_env/src/logger/formatter.rs
index a015f0e48ef..ce2fd74e0e8 100644
--- a/crates/router_env/src/logger/formatter.rs
+++ b/crates/router_env/src/logger/formatter.rs
@@ -205,13 +205,14 @@ where
map_serializer.serialize_entry(VERSION, &self.vers... | 2023-06-20T13:28:36Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [X] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Updated macro invocation from the format! to format_args!
### Additional Changes
- [ ] This PR m... | c40617aea66eb3c14ad47efbce28374cd28626e0 | |
juspay/hyperswitch | juspay__hyperswitch-1288 | Bug: [FEATURE] filter out payment_methods which doesn't support mandates during list api call
### Feature Description
When a mandate payment is created, sdk makes a payment_method_list api call which lists all the payment_methods. But not all of them support mandate payments.
Filter the payment_methods which do... | diff --git a/config/config.example.toml b/config/config.example.toml
index 4f54a4a6c28..06ff14b9818 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -290,6 +290,10 @@ refund_tolerance = 100 # Fake delay tolerance for dummy connector refu
refund_retrieve_duration = 500 # Fake dela... | 2023-05-30T10:23:30Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
When a mandate payment is created, sdk makes a payment_method_l... | 07120bf422048255f93d7073c4dcd2f853667ffd | |
juspay/hyperswitch | juspay__hyperswitch-1276 | Bug: [FEATURE] Implement `RefundInterface` for `MockDb`
Spin out from #172. Please refer to that issue for more information. | diff --git a/crates/router/src/db/refund.rs b/crates/router/src/db/refund.rs
index e3ff8b8dc6d..bb40bd76429 100644
--- a/crates/router/src/db/refund.rs
+++ b/crates/router/src/db/refund.rs
@@ -1,4 +1,4 @@
-use storage_models::errors::DatabaseError;
+use storage_models::{errors::DatabaseError, refund::RefundUpdateIntern... | 2023-05-25T20:32:19Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [X] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the API co... | 6f1a1a3bcb7466738b018a773a5fe4adc5cf2887 | |
juspay/hyperswitch | juspay__hyperswitch-1256 | Bug: Implement `MandateInterface` for `MockDb`
Spin out from https://github.com/juspay/hyperswitch/issues/172. Please refer to that issue for more information. | diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs
index 0bec1c7c081..3cd510b33e5 100644
--- a/crates/router/src/db.rs
+++ b/crates/router/src/db.rs
@@ -112,6 +112,7 @@ pub struct MockDb {
events: Arc<Mutex<Vec<storage::Event>>>,
disputes: Arc<Mutex<Vec<storage::Dispute>>>,
lockers: Arc<Mutex... | 2023-06-08T09:43:46Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [x] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
- fixes #1256
### Additional Changes
- [ ] This PR modif... | 3a225b2118c52f7b28a40a87bbcd8b126b01eeef | |
juspay/hyperswitch | juspay__hyperswitch-1257 | Bug: Implement `LockerMockInterface` for `MockDb`
Spin out from https://github.com/juspay/hyperswitch/issues/172. Please refer to that issue for more information. | diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs
index d5f05bfb73a..0bec1c7c081 100644
--- a/crates/router/src/db.rs
+++ b/crates/router/src/db.rs
@@ -111,6 +111,7 @@ pub struct MockDb {
cards_info: Arc<Mutex<Vec<storage::CardInfo>>>,
events: Arc<Mutex<Vec<storage::Event>>>,
disputes: Arc<M... | 2023-06-04T17:55:08Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the API co... | 65d4a95b59ee950ba67ce5b38688a650c5131149 | |
juspay/hyperswitch | juspay__hyperswitch-1229 | Bug: [BUG] incorrect mapping of connector customer
### Bug Description
It bugs out when the merchant connector account credentials are changed, or when multiple connector accounts with the same name ( stripe, adyen ) are created in different countries or with different labels. When creating payment it will be us... | diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs
index 196d6b4c484..978f89a9f8a 100644
--- a/crates/router/src/core/payments.rs
+++ b/crates/router/src/core/payments.rs
@@ -122,7 +122,6 @@ where
let updated_customer = call_create_connector_customer_if_required(
state,... | 2023-05-25T12:05:37Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Refactoring
## Description
<!-- Describe your changes in detail -->
This PR adds support for multiple country and business label support in the connector customer. Previously the mapping to connector customer was of the form `connector_name ->... | fa392c40a86b2589a55c3adf1de5b862a544dbe9 | |
juspay/hyperswitch | juspay__hyperswitch-1224 | Bug: feat(connector) : [Authorizedotnet] Add Wallet support
Wallet support(google pay, apple pay and paypal) for Authorizedotnet | diff --git a/Cargo.lock b/Cargo.lock
index bd81825ee30..f93aa8d1dc8 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1639,7 +1639,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "907076dfda823b0b36d2a1bb5f90c96660a5bbcd7729e10727f07858f22c4edc"
dependencies = [
"cfg-if",
- "hashbrown",
... | 2023-05-21T18:20:28Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Wallet Support[Paypal, Googlepay and Applepay] for Authorizedot... | 07aef53a5cd4cd70f75415e883d0e07d85244a1e | |
juspay/hyperswitch | juspay__hyperswitch-1296 | Bug: [FEATURE] Create a new workflow to validate the generated openAPI spec file (generated.json)
### Feature Description
There should be a check for validating the `generated.json` file whenever a change is pushed in the codebase.
### Possible Implementation
We can configure a new workflow via **GitHub Act... | diff --git a/Cargo.lock b/Cargo.lock
index 3690b937999..50173a250e5 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -11,7 +11,7 @@ dependencies = [
"actix-rt",
"actix_derive",
"bitflags 1.3.2",
- "bytes",
+ "bytes 1.4.0",
"crossbeam-channel",
"futures-core",
"futures-sink",
@@ -20,10 +20,10 @@ dependencies = [
... | 2023-05-31T10:26:11Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] New feature
- [x] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR adds a new workflow in the CI pipeline to validate the generated openAPI spec file(`openapi_spec.json`). It utilizes the [Swagger CLI](https://apitools.de... | 1322aa757902662a1bd90cc3f09e887a7fdbf841 | |
juspay/hyperswitch | juspay__hyperswitch-1218 | Bug: fix(connector) : [Globalpay] unit tests for globalpay
refactor and add unit tests for globalpay | diff --git a/crates/router/src/connector/globalpay.rs b/crates/router/src/connector/globalpay.rs
index 5bd472a2d04..ac0797cc89a 100644
--- a/crates/router/src/connector/globalpay.rs
+++ b/crates/router/src/connector/globalpay.rs
@@ -15,6 +15,7 @@ use self::{
GlobalpayRefreshTokenResponse,
},
};
+use supe... | 2023-05-19T19:54:24Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
This PR contains following changes
1)unit tests for globalpay... | 4a8de7741d43da07e655bc7382927c68e8ac1eb5 | |
juspay/hyperswitch | juspay__hyperswitch-1191 | Bug: Implement `EphemeralKeyInterface` for `MockDb`
Spin out from https://github.com/juspay/hyperswitch/issues/172. Please refer to that issue for more information. | diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs
index 0bec1c7c081..c33d3f00225 100644
--- a/crates/router/src/db.rs
+++ b/crates/router/src/db.rs
@@ -108,6 +108,7 @@ pub struct MockDb {
connector_response: Arc<Mutex<Vec<storage::ConnectorResponse>>>,
redis: Arc<redis_interface::RedisConnectionP... | 2023-05-27T10:25:12Z | ## Type of Change
- [ ] Bugfix
- [X] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Implemented Mock db for ephemeral key
### Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database sc... | 638fc42217861924b5a43d33d691bad63338cac3 | |
juspay/hyperswitch | juspay__hyperswitch-1211 | Bug: feat: add cache for MCA and API key tables.
Add support for in memory and redis cache for Merchant Connector Account and API keys tables to the functions that are frequently called for less latency during payments. | diff --git a/crates/router/src/db/api_keys.rs b/crates/router/src/db/api_keys.rs
index 3d1c2d6bb34..70e2cb99f92 100644
--- a/crates/router/src/db/api_keys.rs
+++ b/crates/router/src/db/api_keys.rs
@@ -1,6 +1,8 @@
use error_stack::IntoReport;
use super::{MockDb, Store};
+#[cfg(feature = "accounts_cache")]
+use crate... | 2023-05-19T09:43:47Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Enhancement
## Description
<!-- Describe your changes in detail -->
This PR adds in memory and redis cache for Merchant Connector Account and API keys. To the fetch functions that are frequently called during a payment
This PR closes #1211.
... | b967d232519b106d88d79da2d6baec550c9256df | |
juspay/hyperswitch | juspay__hyperswitch-1189 | Bug: Implement `CardsInfoInterface` for `MockDb`
Spin out from #172. Please refer to that issue for more information. | diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs
index 6863ddf1eb6..ee9cd03e692 100644
--- a/crates/router/src/db.rs
+++ b/crates/router/src/db.rs
@@ -84,6 +84,7 @@ pub struct MockDb {
connector_response: Arc<Mutex<Vec<storage::ConnectorResponse>>>,
redis: Arc<redis_interface::RedisConnectionPoo... | 2023-05-24T22:27:18Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Very simply implement `CardsInfoInterface` for `MockDB`, allo... | 16cd32513bc6528e064058907a8c3c848fdba132 | |
juspay/hyperswitch | juspay__hyperswitch-1209 | Bug: Change type name from `MandateTxnType` to `MandateTransactionType`
Would be preferable if we could avoid the `Txn` and use `Transaction` instead. I'm okay with taking this up on a separate PR.
_Originally posted by @SanchithHegde in https://github.com/juspay/hyperswitch/pull/1188#discussion_r11... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index bcdb75824c1..c5e0e6977ca 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -341,9 +341,9 @@ pub struct VerifyRequest {
#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
#[serd... | 2023-05-31T07:24:23Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement
- [x] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Change type name from MandateTxnType to MandateTransactionType,... | e575fde6dc22675af18e80b005872dec2f6cc22c | |
juspay/hyperswitch | juspay__hyperswitch-1199 | Bug: [FEATURE] List payment_methods with the required fields in each method
### Feature Description
When /payments API call is made from merchant server, payment is created. Assume that customer hasn't sent the required field in this call. But when a `confirm` API call is made, since customer has missed to send t... | diff --git a/config/config.example.toml b/config/config.example.toml
index 2d43669ea1d..cbe1af472fd 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -286,3 +286,12 @@ refund_duration = 1000 # Fake delay duration for dummy connector refun
refund_tolerance = 100 # Fake dela... | 2023-05-29T17:22:30Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Currently when `/payments` API call is made with `confirm = fal... | 9794079c797dcb30edcd88e93e8448948321287c | |
juspay/hyperswitch | juspay__hyperswitch-1185 | Bug: feat(Connector): [Noon] Add Cards payments, Refunds, Capture and Void
### Feature Description
AddSupport for payments with Non-3DS cards via Noon.
Includes:
- [Authorize](https://docs.noonpayments.com/payment-api/reference/initiate)
- [Capture](https://docs.noonpayments.com/payment-api/reference/capture)... | diff --git a/crates/api_models/src/enums.rs b/crates/api_models/src/enums.rs
index 0b1726daaa7..f91732cfa73 100644
--- a/crates/api_models/src/enums.rs
+++ b/crates/api_models/src/enums.rs
@@ -616,7 +616,7 @@ pub enum Connector {
Multisafepay,
Nexinets,
Nmi,
- // Noon, added as template code for futur... | 2023-05-18T13:44:42Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [X] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Added Card Payments (3DS and Non-3DS) along with all the list... | c1b631bd1e0025452f2cf37345996ea789810839 | |
juspay/hyperswitch | juspay__hyperswitch-1190 | Bug: Implement `DisputeInterface` for `MockDb`
Spin out from https://github.com/juspay/hyperswitch/issues/172. Please refer to that issue for more information. | diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs
index 9023cf71d07..317e8d34fac 100644
--- a/crates/router/src/db.rs
+++ b/crates/router/src/db.rs
@@ -118,6 +118,7 @@ pub struct MockDb {
api_keys: Arc<Mutex<Vec<storage::ApiKey>>>,
cards_info: Arc<Mutex<Vec<storage::CardInfo>>>,
events: Arc<... | 2023-06-03T20:53:21Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
### Additional Changes
- [ ] This PR modifies the API co... | 10691c5fce630d60aade862080d25c62a5cddb44 | |
juspay/hyperswitch | juspay__hyperswitch-1173 | Bug: feat(connector) : [Authorizedotnet] Webhooks support for Authorizedotnet
payment and refund webhook support for authorizedotnet | diff --git a/crates/router/src/connector/authorizedotnet.rs b/crates/router/src/connector/authorizedotnet.rs
index 49869f0137f..83e96138833 100644
--- a/crates/router/src/connector/authorizedotnet.rs
+++ b/crates/router/src/connector/authorizedotnet.rs
@@ -3,6 +3,7 @@ mod transformers;
use std::fmt::Debug;
+use co... | 2023-05-16T14:35:52Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [x] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
<!-- Describe your changes in detail -->
Payments and refund Webhook Flow for Authorizedotnet
### Add... | 7567d831ccb2d46352d2010acb78abe71e807f8d | |
juspay/hyperswitch | juspay__hyperswitch-1139 | Bug: [BUG] Make payment method data accessible for `network_transaction_id`
### Bug Description
In the case of `network_transaction_id` some connectors require payment method data. After the new mandate changes a new payment method `MandatePayment` was introduced, which doesn't consider this use case.
### Expected... | diff --git a/Cargo.lock b/Cargo.lock
index 100e28daaf4..c701a355ebb 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2969,7 +2969,7 @@ dependencies = [
[[package]]
name = "opentelemetry"
version = "0.18.0"
-source = "git+https://github.com/open-telemetry/opentelemetry-rust?rev=44b90202fd744598db8b0ace5b8f0bad7ec45658#44... | 2023-05-11T19:09:36Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [x] Bugfix
- [ ] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
This change fixes the case where connectors require payment data, when network transaction id is passed... | acb91eb4f9d448834eef19aacca1601c3476de82 | |
juspay/hyperswitch | juspay__hyperswitch-1145 | Bug: [FEATURE] add `set_config` route the the configs API
### Feature Description
Currently, API provided are retrieve config and update config. But, inherently there is not way provided to add a config externally. This feature request is to add such a route.
### Possible Implementation
#1144
### Have you spent... | diff --git a/crates/router/src/core/configs.rs b/crates/router/src/core/configs.rs
index b71c31b1043..5f0e7d76c03 100644
--- a/crates/router/src/core/configs.rs
+++ b/crates/router/src/core/configs.rs
@@ -1,3 +1,5 @@
+use error_stack::ResultExt;
+
use crate::{
core::errors::{self, utils::StorageErrorExt, RouterRe... | 2023-05-11T22:39:30Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
Adding an API route to provide ways to add keys and values in database/cache.
Currently, we only have ... | d7cfb4a179083580a7e195fa07077af23a262ceb | |
juspay/hyperswitch | juspay__hyperswitch-1142 | Bug: [BUG] Disable flag from `merchant connector account` isn't validated
### Bug Description
Disable flag from `merchant connector account` isn't validated while making a payment. This would provide degraded merchant experience and is logically invalid.
### Expected Behavior
The payment should throw an error and... | diff --git a/crates/router/src/compatibility/stripe/errors.rs b/crates/router/src/compatibility/stripe/errors.rs
index 78c5c551719..8566d1837a4 100644
--- a/crates/router/src/compatibility/stripe/errors.rs
+++ b/crates/router/src/compatibility/stripe/errors.rs
@@ -91,6 +91,9 @@ pub enum StripeErrorCode {
#[error(e... | 2023-05-11T21:35:10Z | ## Type of Change
<!-- Put an `x` in the boxes that apply -->
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
## Description
The `disabled` field in the merchant connector account, was being populated, but it's presence wasn't b... | fee0e9dadd2e20c5c75dcee50de0e53f4e5e6deb |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.